breaks

I'm doing front breaks on mt 99 528i 90k miles is there any one that has had any trouble with this or is there something i should look for(first time)

Pretty standard job, but I would recommend BMW brake parts. Just as a suggestion, I would flush the brake fluid at this time. Are you do for your Inspection I service?

i thought about bavauto parts the supplies that i need the dealers are so high priced.

Solid blank rotors of any brand.
If you like dust BMW pads are fine otherwise get aftermarket. I recommend Hawk HPS.
If the warning light is on you will need a brake wear sensor. To turn it off leave key in ON for 30 seconds after the repair.
Check the piston dust boots.
You may need a BFHammer to remove the rear rotors. Dont be afraid to hit them hard if you are replacing them. Make sure the Ebrake is off.

Hawk pads are good,lot less dust than stock